Fixed css class not being used by slice container #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
ascott
reviewed
Oct 24, 2016
| @@ -2,6 +2,7 @@ import React, { PropTypes } from 'react'; | |||
| import { connect } from 'react-redux'; | |||
| import { Panel } from 'react-bootstrap'; | |||
| import visMap from '../../../visualizations/main'; | |||
| require('../../../visualizations/directed_force.css'); | |||
There was a problem hiding this comment.
can we include this css only in the visualization files that need it rather than in this component?
There was a problem hiding this comment.
Turned out this line does not need to be used at all when className is specified :)
Deleted it!
|
LGTM |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The className was not specified in slice container earlier, causing specific viz css files not being used.
Before:
After:
Before:
After:
Before:
After:
@ascott